[RFC] Randr 1.3 feature - get property

[Matthias Hopf]

On Mar 06, 08 13:25:31 -0800, Jesse Barnes wrote:
> > > Any thoughts?  Am I on the right track here?
> >
> > Please.  Put a major version number at the start of the output function
> > pointer rec, and append new functions at the end.  Give the server
> > _some_ chance to be ABI compatible.
> diff --git a/hw/xfree86/modes/xf86Crtc.h b/hw/xfree86/modes/xf86Crtc.h
> index cc045b2..72cfbc4 100644
> --- a/hw/xfree86/modes/xf86Crtc.h
> +++ b/hw/xfree86/modes/xf86Crtc.h
> @@ -215,8 +215,15 @@ typedef struct _xf86CrtcFuncs {
>  		      Rotation rotation, int x, int y);
>  } xf86CrtcFuncsRec, *xf86CrtcFuncsPtr;
>  
> +#define XF86_CRTC_VERSION 1
> +
>  struct _xf86Crtc {
>      /**
> +     * ABI versioning, see xf86CrtcCreate
> +     */
> +    int version;
> +
> +    /**
>       * Associated ScrnInfo
>       */
>      ScrnInfoPtr	    scrn;

Isn't this again changing the ABI?
Note that I don't have a better idea, except adding the version number
further down in the struct, which of course is a bit cumbersome...

Matthias

-- 
Matthias Hopf <mhopf at suse.de>      __        __   __
Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__          mat at mshopf.de
Phone +49-911-74053-715           __)  |_|  __)  |__  R & D   www.mshopf.de