[RFC] Randr 1.3 feature - get property

[Alex Deucher]

On Thu, Mar 6, 2008 at 4:25 PM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> On Thursday, March 06, 2008 11:44 am Adam Jackson wrote:
>
> > On Tue, 2008-03-04 at 17:19 -0800, Jesse Barnes wrote:
>  > > Right now, the Randr core code will just return the current (cached)
>  > > property value when a get property request comes in.  This is fine in
>  > > many cases, but fails in others, for example when fetching backlight
>  > > brightness after some other agent has changed its value.
>  > >
>  > > This patch adds the core server code to call back to a driver's
>  > > get_property routine, which should update the property, which the Randr
>  > > core will then return.
>  > >
>  > > I haven't implemented the i830_lvds.c portion of this, but it should be
>  > > trivial.
>  > >
>  > > Any thoughts?  Am I on the right track here?
>  >
>  > Please.  Put a major version number at the start of the output function
>  > pointer rec, and append new functions at the end.  Give the server
>  > _some_ chance to be ABI compatible.
>
>  Oh, and here's one that actually works.  Turns out the server bits weren't
>  actually wired up yet, so I was modifying a function that was never called.
>
>  I think it's ok at this point and it works with the Intel driver, so unless
>  there are objections I'll go ahead and push it.

Jesse,

Looks good to me.

Alex