[patch] fix another module loader memory leak

Peter Hutterer mailinglists at who-t.net
Tue Feb 19 03:07:58 PST 2008


Maxim Levitsky wrote:
> Hi,
> 
> This patch makes xserver segfault here:
> 
> Backtrace:
> 0: /usr/local/bin/X(xf86SigHandler+0x79) [0x80cba89]
> 1: [0xffffe420]
> 2: /usr/local/bin/X [0x80a8edc]
> 3: /usr/local/bin/X(DuplicateModule+0x29) [0x80aa8c9]
> 4: /usr/local/bin/X(xf86AllocateScreen+0xc8) [0x80d80d8]
> 5: /usr/local/bin/X(xf86ConfigPciEntity+0x177) [0x80d8397]
> 6: /usr/local/lib/xorg/modules/drivers//intel_drv.so [0xb7992131]
> 7: /usr/local/bin/X(xf86CallDriverProbe+0x1f3) [0x80a70c3]
> 8: /usr/local/bin/X(InitOutput+0x760) [0x80a7a40]
> 9: /usr/local/bin/X(main+0x266) [0x8070c96]
> 10: /lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe0) [0xb7b35450]
> 11: /usr/local/bin/X(FontFileCompleteXLFD+0x1e5) [0x80702f1]
> 
> 
> It turns out that mod->name was freed, but still can used by DuplicateModule
> I checked with gdb and the crash happens in NewModuleDesc->xstrdup
> 

I'm writing the git commit msg for the revert right now :)
Sorry.

Cheers,
   Peter



More information about the xorg mailing list