[patch 2/2] xf86modes: validate mode clock for probed modes

Jesse Barnes jbarnes at virtuousgeek.org
Tue Feb 5 13:04:42 PST 2008


On Sunday, January 27, 2008 10:16 pm Hong Liu wrote:
> Some modes claimed in monitor EDID data may not be supported by
> the monitor. So also validating the max clock for probed modes.
>
> Thanks,
> Hong
>
>
> diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c
> index 10db862..ebe3df1 100644
> --- a/hw/xfree86/modes/xf86Crtc.c
> +++ b/hw/xfree86/modes/xf86Crtc.c
> @@ -1410,9 +1410,12 @@ xf86ProbeOutputModes (ScrnInfoPtr scrn, int maxX,
> int maxY) /*
>  	 * Check default modes against monitor max clock
>  	 */
> -	if (max_clock)
> +	if (max_clock) {
>  	    xf86ValidateModesClocks(scrn, default_modes,
>  				    &min_clock, &max_clock, 1);
> +	    xf86ValidateModesClocks(scrn, output_modes,
> +				    &min_clock, &max_clock, 1);
> +	}
>
>  	output->probed_modes = NULL;
>  	output->probed_modes = xf86ModesAdd (output->probed_modes, config_modes);

Applied and pushed.  Should this one also be pushed to the 1.4 branch?

Jesse



More information about the xorg mailing list