[PATCH] Fix sis driver to compile with -Werror=format-security

Alan Cox alan at lxorguk.ukuu.org.uk
Tue Dec 23 10:22:04 PST 2008

> > better patch. On the other hand, if you guys feel there is nothing to be
> > fixed here I'll just keep the patch for the Mandriva package and let it go.
> Change str to a macro and use that:
> #define MSG_SEP "**************************************************\n"
> ...
> xf86DrvMsg(pScrn->scrnIndex, X_ERROR, MSG_SEP);
> ...
> #undef MSG_STR


Thats horrible on so many levels

1. It uglifiers the code enormously
2. You are trying to hide a compiler thing by confusing the tools, and
the tools will get smarter and work that out


More information about the xorg mailing list