[PATCH] Fix sis driver to compile with -Werror=format-security

Dan Nicholson dbn.lists at gmail.com
Tue Dec 23 10:18:37 PST 2008

On Tue, Dec 23, 2008 at 10:10 AM, Ander Conselvan de Oliveira
<ander at c3sl.ufpr.br> wrote:
> Em Tuesday 23 December 2008 15:43:26 Eric Anholt escreveu:
>> On Tue, 2008-12-23 at 13:25 -0200, Ander Conselvan de Oliveira wrote:
>> > The attached patch fix the sis driver to compile with
>> > -Werror=format-security.
>> Some of those strings are predefined and visible in the patch you posted
>> (not a security issue).  I certainly wouldn't apply this patch.
> To be honest, I was not concerned with the security issues this might have but
> with the fact that is does not compile. Mandriva's build system sets this
> flag by default and this might be the case for other distros.
> If there is a better fix for the compilation issue I'll be happy to send a
> better patch. On the other hand, if you guys feel there is nothing to be
> fixed here I'll just keep the patch for the Mandriva package and let it go.

Change str to a macro and use that:

#define MSG_SEP "**************************************************\n"
xf86DrvMsg(pScrn->scrnIndex, X_ERROR, MSG_SEP);
#undef MSG_STR


More information about the xorg mailing list