[PATCH] Include sdk header dependencies and protect agains't multiple inclusion.

Joerg Sonnenberger joerg at britannica.bec.de
Wed Dec 17 12:52:48 PST 2008


On Wed, Dec 17, 2008 at 03:34:04PM -0500, Thomas Dickey wrote:
> On Wed, Dec 17, 2008 at 06:23:09PM -0200, Paulo C?sar Pereira de Andrade wrote:
> >   The patch as a whole may not be required to apply, and not
> > that patch "verbatim", as it would require still at least a
> > review to ensure every sdk header "passes" the:
> > ifdef HAVE_FOO_CONFIG_H
> > #include <foo-config.h>
> > #endif
> 
> It's failure-prone, and increases the amount of work for developers.
> I didn't see any figures on how much faster the build would be,
> to compensate for this.

With any non-braindead compiler, it is the same as just including the
file with include guards. E.g. GCC knows about such include files and
optimises the include away for any but the first time.

Joerg



More information about the xorg mailing list