[PATCH] Include sdk header dependencies and protect agains't multiple inclusion.

Paulo César Pereira de Andrade pcpa at mandriva.com.br
Wed Dec 17 12:50:46 PST 2008

Thomas Dickey wrote:
> On Wed, Dec 17, 2008 at 06:23:09PM -0200, Paulo César Pereira de Andrade
> wrote:
>>   The patch as a whole may not be required to apply, and not
>> that patch "verbatim", as it would require still at least a
>> review to ensure every sdk header "passes" the:
>> #include <foo-config.h>
>> #endif
> It's failure-prone, and increases the amount of work for developers.
> I didn't see any figures on how much faster the build would be,
> to compensate for this.

  The <foo-config.h> headers are {xkb,dix,xorg}-config.h, and they
declare things like:
#define XF86VIDMODE 1
#define XINERAMA 1
#define DRI2 1

  But (most of) those are "moved" to xorg-server.h in an installed

  I don't think the compiler parsing a few extra lines will have
much of an impact on compile time. And still, if one would need
to choose to have the compile time increase by 1% but make it
easier to manage the sources, it would be preferable.

  About those:
#define FEATURE 1
I think they should also be reworked to have enough fallbacks/stubs
to not cause a failure due to things like missing symbols. The
driver should be compiled with the proper sdk headers, but that is
not always the case...

> --
> Thomas E. Dickey
> http://invisible-island.net
> ftp://invisible-island.net


More information about the xorg mailing list