Let the DDX decide on the XkbRulesDefaults.

Dan Nicholson dbn.lists at gmail.com
Wed Dec 17 05:42:12 PST 2008


On Tue, Dec 16, 2008 at 11:28 PM, Daniel Stone <daniel at fooishbar.org> wrote:
> On Tue, Dec 16, 2008 at 11:04:15PM -0800, Dan Nicholson wrote:
>> The other reason I had in mind was to tie into the keymap cache patch
>> I sent. Smarter default means better chance you can reuse the cached
>> map. And I definitely agree that the the XkbSetRulesDflts API is not
>> exactly the way you'd envision things working. Would it be better at
>> some point to have a new function where the driver just passes in the
>> RMLVO it wants instead of setting new defaults and then passing in a
>> (probably empty) XkbComponentNamesRec? Then the DDX could just set the
>> defaults once instead of having them continually blown away.
>
>  extern Bool InitKeyboardDeviceStruct(
> -    DevicePtr /*device*/,
> -    KeySymsPtr /*pKeySyms*/,
> -    CARD8 /*pModifiers*/[],
> +    DeviceIntPtr /*device*/,
> +    XkbRMLVOSet * /*rmlvo*/,
>     BellProcPtr /*bellProc*/,
>     KbdCtrlProcPtr /*controlProc*/);
>
> It's a WIP.

I see you're not too worried about breaking the ABI. :) I suppose kbd
and evdev are the only two drivers that are actually going to call the
*InitKeyboardDeviceStruct anyway and would be easy to fix.

--
Dan



More information about the xorg mailing list