POSTING_READ changes to intel driver

Keith Packard keithp at
Tue Mar 13 21:37:55 PDT 2007

Reviewing the patch recently made that added POSTING_READ calls to the
intel driver to make sure any PCI writes are flushed before the driver
pauses, I had two comments.

1) i830_sdvo_write_sdvox is nearly always followed by an immediate
POSTING_READ invocation. Any reason not to just move the posting inside
the function?

2) in the i830_sdvo_dpms function, explicit writes are made to the SDVO
registers; any reason not to use i830_sdvo_write_sdvox?

keith.packard at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <>

More information about the xorg mailing list