i810 modesetting dist fixes

Ross Burton ross at burtonini.com
Mon Jan 1 12:04:13 PST 2007

On Mon, 2007-01-01 at 11:48 -0800, Keith Packard wrote:
> > 2) includes i830.h in i830_xf86Crtc.c so that it builds against older X
> > servers (currently I don't have xserver 7.2 built)
> This "shouldn't" be necessary; the eventual goal is to make
> i830_xf86Crtc.c part of xfree86/common. Can you explain what is broken
> here?

M_T_PREFERRED isn't defined in xorg 7.1, but is defined in i830.h if it
isn't defined already.

> > 3) adds includes for math.h, string.h and so on as required to stop
> > warnings about undefined free(), fabs(), etc.
> calls to 'free' are not valid in X server code; those are just bugs. I'm
> not getting any missing prototypes though, what are you building on?

Stock edgy with gcc 4.1.2.  I'll get a clean checkout from git and put
the logs online.

Ross Burton                                 mail: ross at burtonini.com
                                          jabber: ross at burtonini.com
                                     www: http://www.burtonini.com./
 PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF

More information about the xorg mailing list