xf86-video-intel

[Sergio Monteiro Basto]

On Wed, 2007-11-28 at 12:35 -0800, Jesse Barnes wrote:
> On Wednesday, November 28, 2007 1:08 am Lukas Hejtmanek wrote:
> > On Sat, Nov 24, 2007 at 03:34:57AM +0000, Sergio Monteiro Basto wrote:
> > > Lukas, I see 3 patches in this tread, what is the best combination ?
> > > "also something" say that is this patch more something, should I apply
> > > all of the 3 or just yours 2 ?
> > > I have applied yours 2 and no crash nor flicks.
> >
> > You should apply all 3 patches to have the backlight behaving mostly
> > correct.
> 
> Does this patch work for you guys?
Sorry no, 

@@ -363,6 +363,7 @@ i830SetLVDSPanelPower(xf86OutputPtr output, Bool on)
 
 	dev_priv->set_backlight(output, dev_priv->backlight_duty_cycle);
     } else {
+	dev_priv->backlight_duty_cycle = dev_priv->get_backlight(output);
 	dev_priv->set_backlight(output, 0);
 
 	OUTREG(PP_CONTROL, INREG(PP_CONTROL) & ~POWER_TARGET_ON);

put my screen all back (or in blacklight permanently ) 


I'm using this instead :

diff --git a/src/i830_lvds.c b/src/i830_lvds.c
index a3a56f7..ab6b472 100644
--- a/src/i830_lvds.c
+++ b/src/i830_lvds.c
@@ -355,6 +354,14 @@ i830SetLVDSPanelPower(xf86OutputPtr output, Bool on)
     I830Ptr                pI830 = I830PTR(pScrn);
     CARD32                 pp_status;

+    /* We need to save current backlight level which can be different from
+     * the server start up so that we restore it correctly.
+     * We assume that if LVDS is turned on, it contains also correct backlight
+     * level.
+     */
+    if (INREG(PP_CONTROL) & POWER_TARGET_ON)
+        dev_priv->backlight_duty_cycle = dev_priv->get_backlight(output);
+
     if (on) {
        OUTREG(PP_CONTROL, INREG(PP_CONTROL) | POWER_TARGET_ON);
        do {
 

> 
> It properly gets the backlight at startup time, saves and restores it across 
> DPMS on/off calls, and doesn't mess with it at startup time (iow it assumes 
> you have it where you want it when you start X).
> 
> Thanks,
> Jesse
-- 
Sérgio M. B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2192 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20071202/7a09971d/attachment.bin>