giuseppe.bilotta at gmail.com
Tue Apr 24 17:26:37 PDT 2007
On Wednesday 25 April 2007 02:04, Daniel Stone wrote:
> On Wed, Apr 25, 2007 at 01:38:32AM +0200, Giuseppe Bilotta wrote:
> Patches 1, 2 and 3 Acked-By: Daniel Stone <daniel at fooishbar.org>. Patch
> 4 is fine bar the ChangeLog and PACKAGE_VERSION_* stuff. Though I'm
> amazed that you caught it, since every other driver seems constantly
> broken in this regard.
Yep, I realized that myself, as I mentioned in the other mail. I have
patches for that queued, even for evdev :)
> As a couple of stylistic comments, there are some pretty excessive
> xf86Msgs (e.g. for DeviceProc), and it could probably do with some
> overall linewrapping.
Yep, the file is in a very sad state. Making it work was the highest
priority, but I plan to reindent the whole thing and demote the debug
messages to their appropriate status (debug). Is there some script I can
run to make the source code comply with the X.org coding styles?
> Also, if your commit message could be a little
> more descriptive and the subjects a little shorter, that'd be great too.
I'll work on that :)
> But, thanks, and welcome! :) I'll add your account in the morning;
> please don't forget to update doc/xorg-docs/MAINTAINERS when you get it.
Sure, and thank *you*.
Giuseppe "Oblomov" Bilotta
More information about the xorg