please test patches to make Xos_r.h generated based on configure

[Daniel Stone]

On Sat, Dec 09, 2006 at 06:49:59AM -0800, Kean Johnston wrote:
> >Or do you have any comments for this?
> I have one.
> 
> Why define, for example, _XOS_R_H_MTSAFE_DIRENTAPI in the configure
> script and at the top of Xos_r.h, only to use it later as:
> # if defined(_XOS_R_H_MTSAFE_DIRENTAPI)
> #  define XOS_USE_MTSAFE_DIRENTAPI 1
> #endif
> 
> Why dont you just make the check in the configure script simply
> set XOS_USE_MTSAFE_DIRENTAPI directly? It shortens the header
> file some and makes it a bit easier to read.

Indeed, why use #defines at all?  Why not just generate the entire file?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20061209/f2125b21/attachment.pgp>