please test patches to make Xos_r.h generated based on configure

Kean Johnston kean at armory.com
Sat Dec 9 06:49:59 PST 2006


> Or do you have any comments for this?
I have one.

Why define, for example, _XOS_R_H_MTSAFE_DIRENTAPI in the configure
script and at the top of Xos_r.h, only to use it later as:
# if defined(_XOS_R_H_MTSAFE_DIRENTAPI)
#  define XOS_USE_MTSAFE_DIRENTAPI 1
#endif

Why dont you just make the check in the configure script simply
set XOS_USE_MTSAFE_DIRENTAPI directly? It shortens the header
file some and makes it a bit easier to read.

Kean




More information about the xorg mailing list