screenSaverSuspended needs to move to os/WaitFor.c

Keith Packard keithp at keithp.com
Tue Apr 4 17:35:50 PDT 2006


On Tue, 2006-04-04 at 23:29 +0200, Fredrik Höglund wrote:
> On Tuesday 04 April 2006 05:30, Keith Packard wrote:
> > X servers which don't include the screen saver extension will fail to
> > link because screenSaverSuspended is not defined. Moving this from the
> > extension to WaitFor.c will solve this problem. 
> 
> Actually I think the problem here is the link order for the binary, since
> the code in WaitFor.c that uses this variable should be #ifdef'ed out
> when the screensaver extension is disabled. Basically os needs to be
> linked in before Xext.

No, in this case, the extension is globally enabled, but the Xdmx server
doesn't link the module in.

> I guess it makes sense to simply put this variable in the DIX globals
> with the other screensaver and DPMS variables.

Yup.

> I'll see about getting those changes into CVS shortly.

Thanks; it's a bugfix, so please commit to HEAD and the release branch.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20060404/b24f922e/attachment.pgp>


More information about the xorg mailing list