Proposal for integrating Looking Glass Xorg Mods into Xorg Release 7.1

Jesse Barnes jbarnes at virtuousgeek.org
Fri Dec 30 18:08:01 PST 2005


On Sunday, December 25, 2005 10:54 am, Deron Johnson wrote:
> When it was possible I put code in separate files. But if there was
> just one or two changes in a file it would have created more problems
> and a bigger change breaking it out into a separate file. For the
> event subsystem, which incurred the most changes, this code is such a
> hairball to begin with that the changes needed to be made in line.
>
> We can restructure the changes however it makes sense. At this point
> I am more concerned about getting the functionality and interfaces
> correct. The issue of what goes in what files is secondary.

Sounds about right, though I agree with Christoph that adding more 
#ifdefs will just cause trouble in the long run (there are already far 
too many to begin with--we should be removing them, not adding them).

Maybe you can post some of the interface changes to the list for review?  
Based on the web page you posted, it sounds like many of the bug fixes 
should just go in directly, along with the bulk of the extension.  If 
possible, the event layer stuff can be abstracted out a bit so that the 
resulting code is at least somewhat maintainable, maybe you have ideas 
for some cleanups that should be done to make that easier/doable?

Jesse



More information about the xorg mailing list