Proposal for integrating Looking Glass Xorg Mods into Xorg Release 7.1

[Deron Johnson]

When it was possible I put code in separate files. But if there was just
one or two changes in a file it would have created more problems and
a bigger change breaking it out into a separate file. For the event
subsystem, which incurred the most changes, this code is such a hairball
to begin with that the changes needed to be made in line.

We can restructure the changes however it makes sense. At this point
I am more concerned about getting the functionality and interfaces
correct. The issue of what goes in what files is secondary.

Christoph Hellwig wrote On 12/25/05 02:59,:
> On Fri, Dec 23, 2005 at 02:41:24PM -0800, Deron Johnson wrote:
> 
>>I have been discussing with Paul Anderson the integration of Project
>>Looking Glass modifications for Xorg Release 7.1.  All of the source
>>modifications are enclosed in #ifdef LG3D, so they are easy to
>>identify. The plan is to integrate these modifications into 7.1 but
>>have the LG3D symbol be undefined by default.
> 
> 
> This sounds like away towards a maintaince desaster.  Ifdefs all over
> the tree will give your a single source tree without different behaviour
> all over.  It would be much better if you kept new code in separate
> files with a few central places that call out to it.
> 
> _______________________________________________
> xorg mailing list
> xorg at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg