Showstopper: core dump in fixup_video_driver_list

Adam Jackson ajax at nwnk.net
Tue Dec 20 09:09:54 PST 2005


On Tuesday 20 December 2005 01:13, Kean Johnston wrote:
> All,
>
> I found another serious problem with current HEAD.
> fixup_video_driver_list runs off the end of the array and causes a core
> dump if atimisc was already after ati in the driver list. This happens
> becuase the variable 'drv' is being re-used in the inner loop, which
> means that when the outer loops comes to increment 'drv', it will
> proceed infinitum becuase it is already past the 'end' marker. The
> attached patch fixes the problem as well as fixing a stylistic
> issue of compound statements on a single line, which makes debugging
> more difficult than it needs to be.

I like https://bugs.freedesktop.org/show_bug.cgi?id=5359 better.

This one is my fault, I'm okay with fixing it if the other RMs agree (and 
assuming they don't flay me for doing so).

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20051220/65215998/attachment.pgp>


More information about the xorg mailing list