Showstopper: core dump in fixup_video_driver_list

Kean Johnston kean at armory.com
Mon Dec 19 22:13:41 PST 2005


All,

I found another serious problem with current HEAD.
fixup_video_driver_list runs off the end of the array and causes a core 
dump if atimisc was already after ati in the driver list. This happens 
becuase the variable 'drv' is being re-used in the inner loop, which
means that when the outer loops comes to increment 'drv', it will
proceed infinitum becuase it is already past the 'end' marker. The
attached patch fixes the problem as well as fixing a stylistic
issue of compound statements on a single line, which makes debugging
more difficult than it needs to be.

Kean

-- 
Deckard: "I don't work here anymore. Give it to Holden. He's good."
Bryant : "I did. He can breathe okay as long as nobody unplugs him."
       --- Bladerunner
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rc2.diff
URL: <http://lists.x.org/archives/xorg/attachments/20051219/f8bf5fb5/attachment.ksh>


More information about the xorg mailing list