Panel resolution derivation problem?

[Michel Dänzer]

On Thu, 2004-09-16 at 22:24 -0700, Daniel Stone wrote:
> Hi all,
> Looking over radeon_driver.c, in RADEONGetPanelInfoFromReg:
>     if (fp_vert_stretch & RADEON_VERT_STRETCH_ENABLE) { 
>         info->PanelYRes = (fp_vert_stretch>>12) + 1;
>     } else {
>         info->PanelYRes = (INREG(RADEON_CRTC_V_TOTAL_DISP)>>16) + 1;
>     }
>     if (fp_horz_stretch & RADEON_HORZ_STRETCH_ENABLE) {
>         info->PanelXRes = ((fp_vert_stretch>>16) + 1) * 8;
>     } else {
>         info->PanelXRes = ((INREG(RADEON_CRTC_H_TOTAL_DISP)>>16) + 1) * 8;
>     }
> 
> I'm not entirely sure about this, but shouldn't the PanelXRes line when
> stretching is enabled, read 'info->PanelXRes = ((fp_horz_stretch>>16) +
> 1) * 8'?  Deriving from fp_vert_stretch instead seems a little wrong to
> me.

Good catch.


-- 
Earthling Michel Dänzer      |     Debian (powerpc), X and DRI developer
Libre software enthusiast    |   http://svcs.affero.net/rm.php?r=daenzer