Panel resolution derivation problem?

[Daniel Stone]

Hi all,
Looking over radeon_driver.c, in RADEONGetPanelInfoFromReg:
    if (fp_vert_stretch & RADEON_VERT_STRETCH_ENABLE) { 
        info->PanelYRes = (fp_vert_stretch>>12) + 1;
    } else {
        info->PanelYRes = (INREG(RADEON_CRTC_V_TOTAL_DISP)>>16) + 1;
    }
    if (fp_horz_stretch & RADEON_HORZ_STRETCH_ENABLE) {
        info->PanelXRes = ((fp_vert_stretch>>16) + 1) * 8;
    } else {
        info->PanelXRes = ((INREG(RADEON_CRTC_H_TOTAL_DISP)>>16) + 1) * 8;
    }

I'm not entirely sure about this, but shouldn't the PanelXRes line when
stretching is enabled, read 'info->PanelXRes = ((fp_horz_stretch>>16) +
1) * 8'?  Deriving from fp_vert_stretch instead seems a little wrong to
me.

Cheers,
d

-- 
Daniel Stone                                            <daniel at freedesktop.org>
freedesktop.org: powering your desktop                http://www.freedesktop.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20040916/b7a43efb/attachment.pgp>