Patch to fix some build errors/warnings

Stefan Dirsch sndirsch at suse.de
Tue Jun 14 07:53:27 PDT 2005


On Tue, Jun 14, 2005 at 11:36:54PM +1000, Daniel Stone wrote:
> Hi Stefan,
> Some comments on a couple of fixes.
> 
> On Tue, Jun 14, 2005 at 03:22:21PM +0200, Stefan Dirsch wrote:
> > lib/X11/src/imTrans.c
> > * imTrans.c:67: warning: implicit declaration of function '_XimXTransOpenCOTSClient'
> > * imTrans.c:67: warning: nested extern declaration of '_XimXTransOpenCOTSClient'
> > * imTrans.c:68: warning: assignment makes pointer from integer without a cast
> 
> These sorts of errors should be correct by ensuring the declaration gets
> seen by all its users,  This should be fixable by defining TRANS_CLIENT?
> 
> [...]
> 
> > lib/ICE/src/accept.c
> > * accept.c:54: warning: implicit declaration of function '_IceTransAccept'
> > * accept.c:54: warning: nested extern declaration of '_IceTransAccept'
> > * accept.c:54: warning: assignment makes pointer from integer without a cast
> 
> And this with TRANS_SERVER, off the top of my head.
> 
> [...]
> 
> > * XRes.c:17:33: error: X11/extensions/XRes.h: No such file or directory
> 
> This should be solved by putting AM_CFLAGS = -I$(top_srcdir)/include in
> the relevant directory's Makefile.am, not by editing the configure.ac
> (which will break srcdir != objdir builds anyway).
> 
> > Hopefully this patch or at least parts of this patch could be included
> > in CVS for the future after discussing it. It's against X.Org / X.Org
> > modular CVS of today.
> 
> Thanks very much for your patch!  I'm kind of preoccupied at the moment,
> but I'll look into these tonight and merge the fixes later on.

Thanks! I'll let you know, if your changes fix my build problems, so I
can finally get rid of my patch.

Stefan

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
------------------------------------------------------


More information about the xorg-modular mailing list