[Xorg-driver-geode] [Bug 51360] GNOME notification icons drawn all-black

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51360

--- Comment #8 from Mart Raudsepp <leio at gentoo.org> ---
The exiting out of the loop approach would defeat the purpose of a lot of the
changes made by Frank in that area, in particular handling of destination
drawing area being larger than the source pixmap for PictOpSrc cases (but not
negative srcX/Y, just larger drawing width/height than source pixmap
dimensions).
So after some brewing I pushed a different variable tweaking commit that should
just make it so that only the source pixmap is composited in this specific case
that was completely mishandled before (negative srcX/Y), which should even be
correct for PictOpOver, but not so much for PictOpSrc - but I believe not much
cases in the wild should need that black rendering for borders, as that's quite
undesired to have random black borders in real applications I bet. In the icon
case, I believe the rendering is actually to some different pixmap and the
black part isn't shown on screen.
A more extensive and full fixing is in order in the future and I have a good
idea what to do there, but such changes wouldn't be suitable for an impending
stable bugfix release, so hopefully in a major version later on.

Please test the version pushed to GIT if possible, and see that it fixes the
icon bug and doesn't cause any regressions elsewhere.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20121120/978a1b17/attachment.html>