[Xorg-driver-geode] [PATCH 00/21] Patch series available for a pull

[Gaetan Nadon]

On Mon, 2011-11-21 at 16:43 +0200, Martin-Éric Racine wrote:

> 2011/11/21 Gaetan Nadon <memsize at videotron.ca>:
> > There is one more patch that I have failed to push yesterday.
> > That's the important one for FreeBSD which can now build without any tweak.
> 
> Excellent. Thanks for noticing this!

That was my mistake :-(

It was tested by Arrigo on FreeBSD.

> 
> Interrestingly enough, enabling -std=gnu99 exposes this warning:
> 
> ../../src/lx_display.c: In function 'lx_crtc_gamma_set':
> ../../src/lx_display.c:360:9: warning: ISO C90 forbids mixed
> declarations and code [-Wdeclaration-after-statement]
> 

Geode module is now using the warnings/error set-up from util-macros.
Recently some warnings flags have been added. The results may vary
depending if you configure with util-macros 1.4 or from master. But yes,
you may see additional warnings by moving up one notch to C99.

For the curious, try --enable-strict-compilation. This raises the bar
for warnings and stop on error.


> While we're at it, suggestions for updating NEWS, README and TODO are
> welcome, in preparation for 2.11.13.
> 

Sharing experience having cleaned-up hundreds of those: TODO and NEWS
are never maintained, consider deleting them. Historically, many of
those were added due to a misunderstanding of AM_INIT_AUTOMAKE. If you
don't specify the "foreign" option, these files are mandatory and the
package won't build if they are missing. So people just added blank ones
and others felt obligated to write something. ChangeLog, is generated
from git, so it is always up to date. 

> Cheers!
> Martin-Éric


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20111121/387eadd7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-driver-geode/attachments/20111121/387eadd7/attachment.pgp>