<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.32.2"> </HEAD> <BODY> On Mon, 2011-11-21 at 16:43 +0200, Martin-Éric Racine wrote: <BLOCKQUOTE TYPE=CITE> <PRE> 2011/11/21 Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>>: > There is one more patch that I have failed to push yesterday. > That's the important one for FreeBSD which can now build without any tweak. Excellent. Thanks for noticing this! </PRE> </BLOCKQUOTE> That was my mistake :-( It was tested by Arrigo on FreeBSD. <BLOCKQUOTE TYPE=CITE> <PRE> Interrestingly enough, enabling -std=gnu99 exposes this warning: ../../src/lx_display.c: In function 'lx_crtc_gamma_set': ../../src/lx_display.c:360:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] </PRE> </BLOCKQUOTE> Geode module is now using the warnings/error set-up from util-macros. Recently some warnings flags have been added. The results may vary depending if you configure with util-macros 1.4 or from master. But yes, you may see additional warnings by moving up one notch to C99. For the curious, try --enable-strict-compilation. This raises the bar for warnings and stop on error. <BLOCKQUOTE TYPE=CITE> <PRE> While we're at it, suggestions for updating NEWS, README and TODO are welcome, in preparation for 2.11.13. </PRE> </BLOCKQUOTE> Sharing experience having cleaned-up hundreds of those: TODO and NEWS are never maintained, consider deleting them. Historically, many of those were added due to a misunderstanding of AM_INIT_AUTOMAKE. If you don't specify the "foreign" option, these files are mandatory and the package won't build if they are missing. So people just added blank ones and others felt obligated to write something. ChangeLog, is generated from git, so it is always up to date. <BLOCKQUOTE TYPE=CITE> <PRE> Cheers! Martin-Éric </PRE> </BLOCKQUOTE> </BODY> </HTML>