[Xorg-driver-geode] xf86-video-geode: Changes to 'master'
FrankR.Huang at amd.com
Mon Oct 11 18:23:35 PDT 2010
See my reply.
Please see the reply too.
> -----Original Message-----
> From: xorg-driver-geode-bounces+frankr.huang=amd.com at lists.x.org
> [mailto:xorg-driver-geode-bounces+frankr.huang=amd.com at lists.x.org] On
> Behalf Of Matthew Garrett
> Sent: 2010?10?11? 20:51
> To: Huang, FrankR
> Cc: Otavio Salvador; Adam Jackson; xorg-devel at lists.x.org; Geode Mailing
> List; Julien Cristau
> Subject: Re: [Xorg-driver-geode] xf86-video-geode: Changes to 'master'
> Your change means that the function will always return MODE_OK. If
> that's what you want to happen, just remove the entirity of the
> function other than the return statement. There's no point in performing
> various checks that result in the same outcome. You'll probably be able
> to delete some other code as a consequence.
Actually, what I want to happen is for "always return MODE_OK". Just as you(Julien, Ajax) have said, this driver's mode_valid() function should filter out the modes that can not be supported by hardware. I totally agree with this point.
But unfortunately, the structure of this function has changed with the patch 5/29/2010.
It is as follow:
1)... return MODE_OK
2)... return MODE_OK
3)... return MODE_OK
4)... return MODE_BAD
More information about the Xorg-driver-geode