[Xorg-driver-geode] xf86-video-geode: Changes to 'master'

Matthew Garrett mjg59 at srcf.ucam.org
Mon Oct 11 05:51:08 PDT 2010

Your change means that the function will always return MODE_OK. If 
that's what you want to happen, just remove the entirity of the 
function other than the return statement. There's no point in performing 
various checks that result in the same outcome. You'll probably be able 
to delete some other code as a consequence.

But the *correct* fix is to figure out why valid modes are being 
rejected. The patch you've posted is just a workaround for some other 
bug, and introduces more bugs in the process. That's why people are 
calling it wrong.

Matthew Garrett | mjg59 at srcf.ucam.org

More information about the Xorg-driver-geode mailing list