[Xorg-driver-geode] Geode GX2 + CS5535 broken GPIO

[Jordan Crouse]

On 05/08/08 12:50 -0400, Gideon Romm wrote:
> Just reporting:
> 
> On Geode GX2 units with CS5535 companion board, the geode driver breaks
> with:
> 
> "Could not find the GPIO I/O base"

Hmm - I'm assuming that you are not using pciaccess - it should still
work for pciaccess, since the 5535 ISA device is in the same slot as
the 5536.  

> Inspection of the code reveals that this is because the CS5536 GPIO
> registers are hard coded in geode_ddc.c.  On a CS5535-based unit, this
> causes the complete system to hang.  The "amd" driver previously and the
> current "nsc" driver do not have this issue.

Hmm - it shouldn't hang - somebody along the line must not like it
when we return NULL from GetDDC.

> I wonder why it was necessary to introduce the hard code for the CS5536.

Just an oversight.

> Also, I do not see any xorg.conf flag or option to disable the DDC probing.
> I think disabling the DDC probe for now, would allow me to use the geode
> driver on this board.

There isn't an xorg.conf option.  If the 'nsc' driver works for you,
then use that.  Otherwise, you can add a check for the 5535 ISA 
device in geode_ddc.c as well (the device number is 0x002b100b).

I'll fix all of the above for the next -geode version.  Thanks
for the bug report.

Jordan

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.