using gr_gb and rg_bg formats for xv for r600+

Roland Scheidegger rscheidegger_lists at hispeed.ch
Thu May 10 19:01:22 PDT 2012


Hi,

I thought those gr_gb and rg_bg formats were a perfect match for packed
yuv data. That should make the code simpler and faster (though unless
you've got some HD3000-class IGPs that shouldn't matter at all).

There's only a slight problem, it doesn't actually work...
The colors are just all wrong, swapping u and v (y/z) doesn't do much it
just is wrong differently. Maybe there's some sign issue somewhere but I
wouldn't see how as it looks like all those values were just set up as
uint8 values before.
I've attached some test images (tested on EG, they were created with
"gst-launch videotestsrc ! xvimagesink"), maybe someone has some idea
what's wrong?
I _thought_ those formats should just work like that (the dri driver
also supports them), the change is fairly trivial (not saying there
can't be other bugs, that shader code is difficult to understand...).


Roland
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testimgnormal.png
Type: image/png
Size: 1414 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-driver-ati/attachments/20120511/71e395e2/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testimgxyz.png
Type: image/png
Size: 1021 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-driver-ati/attachments/20120511/71e395e2/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testimgxzy.png
Type: image/png
Size: 1204 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-driver-ati/attachments/20120511/71e395e2/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: r600_eg_cayman_use_rgbg.diff
Type: text/x-patch
Size: 14836 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-driver-ati/attachments/20120511/71e395e2/attachment.bin>


More information about the xorg-driver-ati mailing list