[PATCH] Fix unused variable warnings.

Dave Airlie airlied at gmail.com
Mon Nov 30 19:50:21 PST 2009


On Tue, Dec 1, 2009 at 11:26 AM, Kusanagi Kouichi <slash at ac.auone-net.jp> wrote:
> On 2009-11-30 11:13:20 -0500, Alex Deucher wrote:
>> On Thu, Nov 26, 2009 at 11:30 PM, Kusanagi Kouichi
>> <slash at ac.auone-net.jp> wrote:
>> > r6xx_accel.c: In function 'wait_3d_idle_clean':
>> > r6xx_accel.c:117: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'wait_3d_idle':
>> > r6xx_accel.c:132: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'cp_set_surface_sync':
>> > r6xx_accel.c:282: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'fs_setup':
>> > r6xx_accel.c:385: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'vs_setup':
>> > r6xx_accel.c:408: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'ps_setup':
>> > r6xx_accel.c:435: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'set_alu_consts':
>> > r6xx_accel.c:465: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'set_bool_consts':
>> > r6xx_accel.c:479: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'set_vtx_resource':
>> > r6xx_accel.c:491: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'set_tex_resource':
>> > r6xx_accel.c:524: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'set_tex_sampler':
>> > r6xx_accel.c:591: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'set_screen_scissor':
>> > r6xx_accel.c:643: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'set_vport_scissor':
>> > r6xx_accel.c:656: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'set_generic_scissor':
>> > r6xx_accel.c:672: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'set_window_scissor':
>> > r6xx_accel.c:686: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'set_clip_rect':
>> > r6xx_accel.c:700: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'draw_immd':
>> > r6xx_accel.c:1109: warning: unused variable 'info'
>> > r6xx_accel.c: In function 'draw_auto':
>> > r6xx_accel.c:1147: warning: unused variable 'info'
>> >
>> > These are really unused.
>>
>> info is used in the accel macros when XF86DRM_MODE is defined.
>>
>> Alex
>
> Oops! Then, how about this patch?

I've fixed this properly in the patch I just pushed to -ati.

without ugly ifdefs.

Dave.


More information about the xorg-driver-ati mailing list