[PATCH] Fix warning about unused defined labels in radeon_exa_funcs.c

Alex Deucher alexdeucher at gmail.com
Thu Nov 5 07:46:39 PST 2009


2009/11/1 Tomáš Chvátal <scarabeus at gentoo.org>:
> Hi,
> I find it bit booring to watch the warning all the time when i recompile the
> xf86-video-ati from git HEAD so i took liberty of writting patchie (see
> attachment).

Pushed.  Thanks!

>
> Also on the same warning notes I would like to know if you care about warnings
> about strict aliasing?
>
> *snip*
>
>  * atombios_crtc.c:438: warning: dereferencing pointer ‘spc2_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:437: warning: dereferencing pointer ‘spc2_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:436: warning: dereferencing pointer ‘spc2_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:435: warning: dereferencing pointer ‘spc2_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:434: warning: dereferencing pointer ‘spc2_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:433: warning: dereferencing pointer ‘spc2_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:432: warning: dereferencing pointer ‘spc2_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:431: warning: dereferencing pointer ‘spc2_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:451: warning: dereferencing pointer ‘spc3_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:450: warning: dereferencing pointer ‘spc3_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:449: warning: dereferencing pointer ‘spc3_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:448: warning: dereferencing pointer ‘spc3_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:447: warning: dereferencing pointer ‘spc3_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:446: warning: dereferencing pointer ‘spc3_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:445: warning: dereferencing pointer ‘spc3_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:444: warning: dereferencing pointer ‘spc3_ptr’ does break
> strict-aliasing rules
>  * atombios_crtc.c:443: warning: dereferencing pointer ‘spc3_ptr’ does break
> strict-aliasing rules
>
> *snip*
>
> I know some upstreams "fix" this by adding -fno-strict-aliasing but basicaly
> this might really result into wrong behaviour under certain moon phases :/
>
> Also my Cfoo is too low to fix it for you, i only think that usage of some nice
> union migth fix it.

Using a union should fix it.  I'll take a look when I get a chance.

Alex


More information about the xorg-driver-ati mailing list