[PATCH] Fix warning about unused defined labels in radeon_exa_funcs.c

Tomáš Chvátal scarabeus at gentoo.org
Sun Nov 1 04:10:39 PST 2009


Hi,
I find it bit booring to watch the warning all the time when i recompile the 
xf86-video-ati from git HEAD so i took liberty of writting patchie (see 
attachment).

Also on the same warning notes I would like to know if you care about warnings 
about strict aliasing?

*snip*

 * atombios_crtc.c:438: warning: dereferencing pointer ‘spc2_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:437: warning: dereferencing pointer ‘spc2_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:436: warning: dereferencing pointer ‘spc2_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:435: warning: dereferencing pointer ‘spc2_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:434: warning: dereferencing pointer ‘spc2_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:433: warning: dereferencing pointer ‘spc2_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:432: warning: dereferencing pointer ‘spc2_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:431: warning: dereferencing pointer ‘spc2_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:451: warning: dereferencing pointer ‘spc3_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:450: warning: dereferencing pointer ‘spc3_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:449: warning: dereferencing pointer ‘spc3_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:448: warning: dereferencing pointer ‘spc3_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:447: warning: dereferencing pointer ‘spc3_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:446: warning: dereferencing pointer ‘spc3_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:445: warning: dereferencing pointer ‘spc3_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:444: warning: dereferencing pointer ‘spc3_ptr’ does break 
strict-aliasing rules
 * atombios_crtc.c:443: warning: dereferencing pointer ‘spc3_ptr’ does break 
strict-aliasing rules

*snip*

I know some upstreams "fix" this by adding -fno-strict-aliasing but basicaly 
this might really result into wrong behaviour under certain moon phases :/

Also my Cfoo is too low to fix it for you, i only think that usage of some nice 
union migth fix it.


Cheers

----------
Tomáš Chvátal
Gentoo Linux Developer [KDE/Overlays/QA/Sunrise/X11]
GnuPG FP        : 94A4 5CCD 85D3 DE24 FE99 F924 1C1E 9CDE 0341 4587
GnuPG ID         : 03414587
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-warning-about-unused-defined-labels-in-radeon_ex.patch
Type: text/x-patch
Size: 2556 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-driver-ati/attachments/20091101/69f52cec/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://lists.x.org/archives/xorg-driver-ati/attachments/20091101/69f52cec/attachment-0001.pgp 


More information about the xorg-driver-ati mailing list