Fix for infinite loop in RADEONGetLVDSInfo on randr-1.2 HEAD

Paul TBBle Hampson Paul.Hampson at
Wed May 16 04:37:21 PDT 2007

On the xrandr1.2 current HEAD's RADEONGetLVDSInfo in radeon_display.c,
while scanning through the modes to find one to use for the flat
panel when the BIOS has been singularly unhelpful (or absent, as on
my PowerBook), the loop will currently become unterminating if a mode
is looked at which doesn't match the panel size.

This is happening to me, because for some reason I'm not getting
modes back from DDC, and as mentioned, have no BIOS to fall back on.
(Different problem, but at least now I can see it in the logs.)

(This all works fine with master HEAD, BTW.)

The below patch fixes the linked-list advancing.

diff --git a/src/radeon_display.c b/src/radeon_display.c
index f0a24ab..d0be3a5 100644
--- a/src/radeon_display.c
+++ b/src/radeon_display.c
@@ -790,8 +790,8 @@ Bool RADEONGetLVDSInfo (xf86OutputPtr output)
 		    radeon_output->Flags = 0;
-		tmp_mode = tmp_mode->next;
+		tmp_mode = tmp_mode->next;
 	if ((radeon_output->DotClock == 0) && !output->MonInfo) {
 	    xf86DrvMsg(pScrn->scrnIndex, X_ERROR,

Paul "TBBle" Hampson, B.Sc, LPI, MCSE
On-hiatus Asian Studies student, ANU
The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361)
Paul.Hampson at

Of course Pacman didn't influence us as kids. If it did,
we'd be running around in darkened rooms, popping pills and
listening to repetitive music.
 -- Kristian Wilson, Nintendo, Inc, 1989

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : 

More information about the xorg-driver-ati mailing list