[PATCH xserver] xfree86: Remove broken RANDR disabling logic (v3)

Keith Packard keithp at keithp.com
Tue Jan 23 21:11:56 UTC 2018


Adam Jackson <ajax at redhat.com> writes:

> The only way to get at xf86Info.disableRandR from configuration is
> Option "RANDR" "foo" in ServerFlags, which probably nobody is using
> seeing as it's not documented. The other way it could be set is if a
> screen supports RANDR 1.2, in which case we set it to avoid trying to
> use the RANDR 1.1 compat code. If the second screen is not 1.2-aware
> then this would mean we don't do RANDR setup on the second screen at
> all, which would almost certainly crash the first time you try to do
> RANDR operations on the second screen.
>
> Fix that all by deletion, and just check whether the screen already has
> RANDR initialized before installing the stub support. If you want to
> disable RANDR, use the Extensions section of xorg.conf instead.
>
> v2: Also remove a now entirely pointless log message, telling you to
> ignore a line we will no longer print.
>
> v3: Explain the fallback path in InitOutput. (Keith Packard)
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>

Looks good to me.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180124/362d13c4/attachment.sig>


More information about the xorg-devel mailing list