[PATCH xserver] xfree86: Remove broken RANDR disabling logic (v2)

Adam Jackson ajax at redhat.com
Tue Jan 23 18:14:40 UTC 2018


On Tue, 2018-01-23 at 08:42 +1100, Keith Packard wrote:
> Adam Jackson <ajax at redhat.com> writes:
> 
> > -        if (!xf86Info.disableRandR)
> > +        if (!rrGetScrPriv(xf86Screens[i]->pScreen))
> >              xf86RandRInit(screenInfo.screens[scr_index]);
> 
> A comment here would help me understand this change; I assume we won't
> generally hit this path, right?

Yeah fair, this is a bit idiomatic. What this is saying is, if the
driver hasn't already initialized randr support for this screen -
meaning, if there's not already a randr screen private - then fill in
the randr hooks for the screen with the 1.1 compat code. 1.2+ drivers
will have called xf86CrtcScreenInit() in their ScreenInit hook before
this point.

- ajax


More information about the xorg-devel mailing list