[PATCH xserver] dri3: Clamp to 1.0 if not all screens support 1.2

Adam Jackson ajax at redhat.com
Tue Apr 24 21:02:17 UTC 2018


On Tue, 2018-04-24 at 21:24 +0100, Daniel Stone wrote:
> Hi Adam,
> 
> On 24 April 2018 at 21:08, Adam Jackson <ajax at redhat.com> wrote:
> > +    for (int i = 0; i < screenInfo.numScreens; i++) {
> > +        if (!dri3_screen_can_one_point_two(screenInfo.screens[i])) {
> > +            rep.minorVersion = 0;
> > +            break;
> > +        }
> > +    }
> > +
> > +    for (int i = 0; i < screenInfo.numGPUScreens; i++) {
> > +        if (!dri3_screen_can_one_point_two(screenInfo.gpuscreens[i])) {
> > +            rep.minorVersion = 0;
> > +            break;
> > +        }
> > +    }
> 
> Makes sense, but would this disable v1.2 for, e.g., UDL?

It would not, assuming the X driver ends up being modesetting, because
ms only has the one dri3 info struct.

- ajax


More information about the xorg-devel mailing list