[PATCH xserver] dri3: Clamp to 1.0 if not all screens support 1.2

Daniel Stone daniel at fooishbar.org
Tue Apr 24 20:24:31 UTC 2018


Hi Adam,

On 24 April 2018 at 21:08, Adam Jackson <ajax at redhat.com> wrote:
> +    for (int i = 0; i < screenInfo.numScreens; i++) {
> +        if (!dri3_screen_can_one_point_two(screenInfo.screens[i])) {
> +            rep.minorVersion = 0;
> +            break;
> +        }
> +    }
> +
> +    for (int i = 0; i < screenInfo.numGPUScreens; i++) {
> +        if (!dri3_screen_can_one_point_two(screenInfo.gpuscreens[i])) {
> +            rep.minorVersion = 0;
> +            break;
> +        }
> +    }

Makes sense, but would this disable v1.2 for, e.g., UDL?

I've sent another one I just spotted by inspection, but this is:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the xorg-devel mailing list