[PATCH xserver] xkb: initialize tsyms

[Eric Engestrom]

On 7 November 2017 09:43:06 GMT, Giuseppe Bilotta <giuseppe.bilotta at gmail.com> wrote:
> On Mon, Nov 6, 2017 at 4:41 PM, Eric Engestrom
> <eric.engestrom at imgtec.com> wrote:
> > On Friday, 2017-11-03 21:38:51 +0100, Giuseppe Bilotta wrote:
> >> This fixes some “Conditional jump depends on uninitialized
> value(s)”
> >> errors spotted by valgrind.
> >>
> >> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta at gmail.com>
> >
> > Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> >
> > Although the rest of the array is 0-initialised, so this only works
> > because NoSymbol is also 0.
> 
> Indeed. I considered clarifying this in a comment, and even just
> making it all 0-initialized with {}. Would that be better?

I think this patch is good, because it explicitly shows the NoSymbol
value that is tested later on. The implicit 0s are fine, but I think adding
a one-sentence explanation to the commit message would be good.

> 
> -- 
> Giuseppe "Oblomov" Bilotta