[PATCH xserver] xkb: initialize tsyms

Giuseppe Bilotta giuseppe.bilotta at gmail.com
Tue Nov 7 09:42:00 UTC 2017


On Mon, Nov 6, 2017 at 4:41 PM, Eric Engestrom
<eric.engestrom at imgtec.com> wrote:
> On Friday, 2017-11-03 21:38:51 +0100, Giuseppe Bilotta wrote:
>> This fixes some “Conditional jump depends on uninitialized value(s)”
>> errors spotted by valgrind.
>>
>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta at gmail.com>
>
> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
>
> Although the rest of the array is 0-initialised, so this only works
> because NoSymbol is also 0.

Indeed. I considered clarifying this in a comment, and even just
making it all 0-initialized with {}. Would that be better?

-- 
Giuseppe "Oblomov" Bilotta


More information about the xorg-devel mailing list