[PATCH xserver 3/2] Rewrite the byte swapping macros.

Eric Anholt eric at anholt.net
Thu Mar 30 15:44:06 UTC 2017


Keith Packard <keithp at keithp.com> writes:

> [ Unknown signature status ]
> Eric Anholt <eric at anholt.net> writes:
>
>> Unaligned accesses trap on some platforms, and I don't think we're
>> guaranteed that the caller has the pointer aligned (at least, the
>> previous code seemed pretty clearly to be trying to work around that, as
>> well).
>
> If it's protocol, then everything is aligned as long as the start of the
> request is aligned.

I've taken a look through the tree, and everything I've looked at
*looks* safe.  Still, I'd like to relax the alignment requirement after
this patch, in case we have to revert.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170330/61fcaf09/attachment.sig>


More information about the xorg-devel mailing list