[PATCH xserver 3/2] Rewrite the byte swapping macros.

Keith Packard keithp at keithp.com
Tue Mar 28 21:00:45 UTC 2017


Eric Anholt <eric at anholt.net> writes:

> Unaligned accesses trap on some platforms, and I don't think we're
> guaranteed that the caller has the pointer aligned (at least, the
> previous code seemed pretty clearly to be trying to work around that, as
> well).

If it's protocol, then everything is aligned as long as the start of the
request is aligned.

> I do like the unit test plan, though.

Always a good idea.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170328/a227a0f8/attachment.sig>


More information about the xorg-devel mailing list