[PATCH util/macros] Add new script xorg-prepare-git-repo.sh

Peter Hutterer peter.hutterer at who-t.net
Wed Feb 8 00:00:03 UTC 2017


On Fri, Feb 03, 2017 at 12:53:07PM +0000, Emil Velikov wrote:
> On 2 February 2017 at 22:04, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> > On Tue, Jan 31, 2017 at 10:24:55AM +0000, Emil Velikov wrote:
> >> From: Emil Velikov <emil.velikov at collabora.com>
> >>
> >> New script invoked by the project's autogen.sh to facilitate basic git
> >> config setup and likely others in the future.
> >>
> >> Ensure that all of output is redirected to /dev/null and the script is
> >> bundled + installed.
> >>
> >> Cc: Peter Hutterer <peter.hutterer at who-t.net>
> >> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> >> ---
> >>  Makefile.am              | 1 +
> >>  xorg-prepare-git-repo.sh | 7 +++++++
> >>  2 files changed, 8 insertions(+)
> >>  create mode 100644 xorg-prepare-git-repo.sh
> >>
> >> diff --git a/Makefile.am b/Makefile.am
> >> index 134a5cc..ff6087a 100644
> >> --- a/Makefile.am
> >> +++ b/Makefile.am
> >> @@ -21,6 +21,7 @@
> >>
> >>  aclocaldir = $(datadir)/aclocal
> >>  aclocal_DATA = xorg-macros.m4
> >> +dist_bin_SCRIPTS = xorg-prepare-git-repo.sh
> >>  dist_pkgdata_DATA = INSTALL
> >>
> >>  # Previous versions used to install xorgversion.m4, now integrated
> >> diff --git a/xorg-prepare-git-repo.sh b/xorg-prepare-git-repo.sh
> >> new file mode 100644
> >> index 0000000..697cee9
> >> --- /dev/null
> >> +++ b/xorg-prepare-git-repo.sh
> >> @@ -0,0 +1,7 @@
> >> +#!/bin/sh
> >> +
> >> +git config --local --get sendemail.to >/dev/null 2>&1 ||
> >> +    git config --local sendemail.to "xorg-devel at lists.x.org" >/dev/null 2>&1
> >> +
> >> +git config --local --get format.subjectPrefix >/dev/null 2>&1 ||
> >> +    git config --local format.subjectPrefix "PATCH $modulename" >/dev/null 2>&1
> >
> > we're going to have to agree on a module name format *now* before we push
> > these to the various repos. Either we go with the split of section +
> > modulename or we go with module name as "section/modulename", including the
> > section being omitted. But this is something that's painful to change, so
> > let's decide on something and live with it.
> >
> > I'd say "section/modulename", any disagreement? If not, I can push this one
> > as-is with a comment in the script to note what $modulename is supposed to
> > look like.
> >
> As long as you guys are happy, I'm fine either way.

Ok, was about to push this but ... if we go with "$section/$module" as
modulename variable this script needs to be extended to work correctly.
Otherwise running it will set the prefix to e.g. "driver/xf86-input-evdev",
we need the extra work to strip out the section.

Cheers,
   Peter


More information about the xorg-devel mailing list