[PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5
Michael Thayer
michael.thayer at oracle.com
Wed Oct 5 19:45:36 UTC 2016
Hello Adam,
On 05.10.2016 21:33, Adam Jackson wrote:
> On Fri, 2016-09-30 at 17:55 +0200, Michael Thayer wrote:
>
>>>
>> v5: Updated the patch to apply to current git HEAD, split up into two
>> patches (server and modesetting driver) and adjusted the code slightly
>> to match surrounding code. I also removed the new exported function
>> ShowCursorCheck(), as instead just changing ShowCursor() to return Bool
>> should not affect its current callers.
>
> I really hate that I have to say this, because it's entirely our fault
> for not having merged this sooner in the cycle, but this is an ABI
> break we can't take after RC1. By changing the layout of
> xf86CrtcFuncsRec, drivers built against RC1 will fail when run against
> RC2. Even adding show_cursor_check to the end of the struct won't help,
> because the server then can't know if the final slot in the struct
> contains valid data.
>
> I have a workaround in mind that will preserve ABI, I'll send it along
> shortly.
Thanks for looking at it. The question though, is whether it still
makes sense to try to merge it for 1.19 or to wait for 1.20, which I
think is Hans' preferred option. I must say that if it means it will
get more testing before becoming part of a release then I tend to lean
that way too. A few pairs of eyes checking the code is good, but not as
good as real use.
Regards,
Michael
>
> - ajax
>
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
More information about the xorg-devel
mailing list