[PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5

[Adam Jackson]

On Fri, 2016-09-30 at 17:55 +0200, Michael Thayer wrote:

> > 
> v5: Updated the patch to apply to current git HEAD, split up into two
> patches (server and modesetting driver) and adjusted the code slightly
> to match surrounding code.  I also removed the new exported function
> ShowCursorCheck(), as instead just changing ShowCursor() to return Bool
> should not affect its current callers.

I really hate that I have to say this, because it's entirely our fault
for not having merged this sooner in the cycle, but this is an ABI
break we can't take after RC1. By changing the layout of
xf86CrtcFuncsRec, drivers built against RC1 will fail when run against
RC2. Even adding show_cursor_check to the end of the struct won't help,
because the server then can't know if the final slot in the struct
contains valid data.

I have a workaround in mind that will preserve ABI, I'll send it along
shortly.

- ajax