[PATCH xserver] os: add an optional offset to -displayfd parameter

[Antoine Martin]

On 13/06/16 23:20, Bernhard Miklautz wrote:
> Hi Antoine,
> 
> thank you for your feedback.
> 
> On 06/13/2016 05:40 PM, Antoine Martin wrote:
>> I think you also need to validate the displayoffset to make sure it
>> isn't greater than 65536 - X_TCP_PORT before you enter the loop.
> Currently if the supplied offset is larger than (65536 - X_TCP_PORT) the loop would never
> run causing the server to exit with an error. Like:
> 
> Xvfb -displayfd 2:59536
> 
> (EE)
> Fatal server error:
> (EE) Failed to find a socket to listen on(EE)
> 
> 
> It would however, probably be a good idea to add an additional error message if the startup fails
> because the supplied offset was to high. What do you think about that?
As long as it fails more or less gracefully, that's fine. And it does, so:
Reviewed-by: Antoine Martin <antoine at nagafix.co.uk>

(feel free to add better validation if you fell like it)

Cheers
Antoine

> 
> Thanks.
> Best regards,
> Bernhard
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel
>