[PATCH xserver] composite: Fix repaint of borders (v2)

Uli Schlachter psychon at znc.in
Sun Dec 11 07:45:23 UTC 2016


On 06.12.2016 20:11, Adam Jackson wrote:
[...]
> @@ -126,19 +127,20 @@ compSetPixmapVisitWindow(WindowPtr pWindow, void *data)
>       */
>      SetWinSize(pWindow);
>      SetBorderSize(pWindow);
> -    if (HasBorder(pWindow))
> +    if (pVisit->bw)
>          QueueWorkProc(compRepaintBorder, serverClient,
>                        (void *) (intptr_t) pWindow->drawable.id);
>      return WT_WALKCHILDREN;
>  }
[...]

Sorry, but I think that this is wrong. The definition of
HasBorder(pWindow) is in include/windowstr.h:

#define HasBorder(w)   ((w)->borderWidth || wClipShape(w))

Your patch drops the shape check.

Cheers,
Uli
-- 
Bruce Schneier can read and understand Perl programs.


More information about the xorg-devel mailing list