[PATCH xserver] composite: Fix repaint of borders (v2)

Adam Jackson ajax at redhat.com
Wed Dec 7 17:42:22 UTC 2016


On Tue, 2016-12-06 at 13:51 -0800, Keith Packard wrote:
> > Adam Jackson <ajax at redhat.com> writes:
> 
> > When going from border width zero to a non-zero border width, the
> > Composite extension is informed via the ConfigNotify callback. The
> > call-chain looks like this: compConfigNotify -> compReallocPixmap ->
> > compSetPixmap -> TraverseTree -> compSetPixmapVisitWindow. However, at
> > this time, pWindow->borderWidth was not yet updated. Thus, HasBorder()
> > is false and the window border will not be repainted.
> > 
> > To fix this, thread the new bw through to the window visitor, and
> > inspect that rather than HasBorder(). For all the other callers the
> > border does not change size, so we can pass pWin->borderWidth instead.
> 
> Yeah, that's a nicer version of this patch.
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>

Thanks. Updated the commit message a bit and merged:

remote: I: patch #125894 updated using rev f31875510d818ba517f082e124adb294db906e51.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   75c4f6e..f318755  master -> master

- ajax


More information about the xorg-devel mailing list