[PATCH] glamor: fix crash when drawing nothing

Keith Packard keithp at keithp.com
Fri Oct 16 08:07:08 PDT 2015

Rob Clark <robdclark at gmail.com> writes:

> On Wed, Oct 14, 2015 at 8:10 PM, Eric Anholt <eric at anholt.net> wrote:
>> Rob Clark <robdclark at gmail.com> writes:
>>> For example, in the PolyFillRect() path w/ nrect==0, we end up in
>>> glamor_get_vbo_space(size=0):
>> I wonder instead if we shouldn't just have glamor_get_vbo_space() return
>> NULL on size == 0?
> that was my first approach, and is a much smaller patch, but triggers
> GL errors on glamor_put_vbo_space().. so with that approach we'd
> either need some bookkeeping to skip the glUnmapBuffer() or live w/
> extra gl errors..

Might be good to do both in case we end up there again; a gl error is a
better result than a segfault?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151016/bffd59ee/attachment.sig>

More information about the xorg-devel mailing list