[PATCH] glamor: fix crash when drawing nothing

Rob Clark robdclark at gmail.com
Wed Oct 14 18:21:34 PDT 2015

On Wed, Oct 14, 2015 at 8:10 PM, Eric Anholt <eric at anholt.net> wrote:
> Rob Clark <robdclark at gmail.com> writes:
>> For example, in the PolyFillRect() path w/ nrect==0, we end up in
>> glamor_get_vbo_space(size=0):
> I wonder instead if we shouldn't just have glamor_get_vbo_space() return
> NULL on size == 0?

that was my first approach, and is a much smaller patch, but triggers
GL errors on glamor_put_vbo_space().. so with that approach we'd
either need some bookkeeping to skip the glUnmapBuffer() or live w/
extra gl errors..

note that somehow MESA_EXTENSION_OVERRIDE="-GL_ARB_buffer_storage" (so
that I could apitrace things) was somehow triggering the initial
problem (but that might be somehow timing related)


More information about the xorg-devel mailing list